Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated motoko examples to functional runtime syntax #1271

Merged
merged 22 commits into from
Sep 26, 2023
Merged

Updated motoko examples to functional runtime syntax #1271

merged 22 commits into from
Sep 26, 2023

Conversation

dansteren
Copy link
Contributor

Closes #1249

@dansteren dansteren force-pushed the 1249_functional_motoko_examples branch 5 times, most recently from 903bf4d to b0d0aea Compare September 25, 2023 22:58
@dansteren dansteren force-pushed the 1249_functional_motoko_examples branch 3 times, most recently from e349e2a to 91f56cd Compare September 26, 2023 16:49
@dansteren dansteren marked this pull request as ready for review September 26, 2023 17:02
@dansteren dansteren marked this pull request as draft September 26, 2023 17:07
@lastmjs lastmjs marked this pull request as ready for review September 26, 2023 17:12
lastmjs
lastmjs requested changes Sep 26, 2023
View reviewed changes
.github/workflows/test.yml Outdated
# "examples/outgoing_http_requests",
# "examples/rejections",
# "examples/motoko_examples/superheroes", # blocked by recursive
# "examples/motoko_examples/whoami", # blocked by postUpgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is whoami not fixed?

examples/motoko_examples/calc/src/index.ts Show resolved Hide resolved
examples/motoko_examples/http_counter/src/index.ts Outdated

// TODO: Figure out tuples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment

examples/motoko_examples/whoami/test/tests.ts Outdated
@@ -16,8 +16,11 @@ const installationPrincipal = execSync(`dfx identity get-principal`)
.toString()
.trim();

console.log(`installationPrincipal is: ${installationPrincipal}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug logs

examples/rejections/canisters/rejections/index.ts Outdated Show resolved Hide resolved
examples/rejections/canisters/rejections/index.ts Outdated Show resolved Hide resolved
src/lib_functional/candid/reference/variant.ts Show resolved Hide resolved
@dansteren dansteren force-pushed the 1249_functional_motoko_examples branch from 91f56cd to cde7785 Compare September 26, 2023 17:58
@dansteren dansteren requested a review from lastmjs September 26, 2023 18:07
@lastmjs lastmjs merged commit 3b5d2c5 into js_rearchitecture Sep 26, 2023
60 checks passed
@dansteren dansteren deleted the 1249_functional_motoko_examples branch September 27, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dansteren @lastmjs